Persist custom configs during provision#132
Merged
Conversation
Signed-off-by: Rajeev Ranjan <rajeev2.ranjan@intel.com>
Signed-off-by: Rajeev Ranjan <rajeev2.ranjan@intel.com>
Signed-off-by: Rajeev Ranjan <rajeev2.ranjan@intel.com>
Signed-off-by: Rajeev Ranjan <rajeev2.ranjan@intel.com>
Signed-off-by: Rajeev Ranjan <rajeev2.ranjan@intel.com>
Signed-off-by: Rajeev Ranjan <rajeev2.ranjan@intel.com>
rranjan3
requested review from
Andrea-Campanella,
Ram-srini,
cjnolan,
daniele-moro,
ipsita-npg,
krishnajs,
nbmaiti,
osinstom,
pierventre,
ppanigra,
punam20,
shankarsrinivas1,
shiva-shankar-k and
vthiruveedula
as code owners
Signed-off-by: Rajeev Ranjan <rajeev2.ranjan@intel.com>
Signed-off-by: Rajeev Ranjan <rajeev2.ranjan@intel.com>
Signed-off-by: Rajeev Ranjan <rajeev2.ranjan@intel.com>
Signed-off-by: Rajeev Ranjan <rajeev2.ranjan@intel.com>
pierventre
reviewed
Jun 13, 2025
pierventre
reviewed
Jun 13, 2025
Contributor
pierventre
left a comment
pierventre
left a comment
There was a problem hiding this comment.
can we improve the tests?
Signed-off-by: Rajeev Ranjan <rajeev2.ranjan@intel.com>
…-platform/infra-onboarding into rranjan3/custom-config
Signed-off-by: Rajeev Ranjan <rajeev2.ranjan@intel.com>
Signed-off-by: Rajeev Ranjan <rajeev2.ranjan@intel.com>
Contributor
Author
Added some tests post refactor of utility function. |
pierventre
reviewed
Jun 20, 2025
pierventre
approved these changes
Jun 20, 2025
Signed-off-by: Rajeev Ranjan <rajeev2.ranjan@intel.com>
pierventre
approved these changes
Jun 23, 2025
pierventre
approved these changes
Jun 23, 2025
Contributor
pierventre
left a comment
pierventre
left a comment
There was a problem hiding this comment.
remeber to update the go.mod before merging
Signed-off-by: Rajeev Ranjan <rajeev2.ranjan@intel.com>
Contributor
Author
|
Verified with latest changes. Able to see the split config files at desired location with expected permissions |
niket-intc
previously requested changes
Jun 27, 2025
Contributor
niket-intc
left a comment
niket-intc
left a comment
There was a problem hiding this comment.
Since the infra.cfg will be the last config file that will be added in the cases custome configs are added, we need to add merge_how directive to tell cloud-init on how to merge.
Under the user data of infra.cfg include this
merge_how:
- name: list
settings: [ append ] - name: dict
settings: [ no_replace, recurse_list ] - name: str
settings: [append]
Signed-off-by: Rajeev Ranjan <rajeev2.ranjan@intel.com>
Signed-off-by: Rajeev Ranjan <rajeev2.ranjan@intel.com>
pierventre
approved these changes
Jun 30, 2025
osinstom
approved these changes
Jul 1, 2025
Signed-off-by: Rajeev Ranjan <rajeev2.ranjan@intel.com>
Contributor
Author
|
Updated merge_how to a on-liner. verified on Ubuntu EN. |
niket-intc
approved these changes
Jul 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Persist custom config for each instance using tinker workflows during provisioning.
Fixes # 66948
Any Newly Introduced Dependencies
Please describe any newly introduced 3rd party dependencies in this change. List their name, license information and how they are used in the project.
How Has This Been Tested?
Created a local onboarding manager image & updated to coder EMF. Image had hardcoded values in customConfigs
deviceInfo.CustomConfigs = make(map[string]string) deviceInfo.CustomConfigs["test1"] = "# test-config1" deviceInfo.CustomConfigs["test2"] = "# test-config2"Checklist: